From 5a6bf4e7c2c05e330d8df349edcc67fc48a25b98 Mon Sep 17 00:00:00 2001 From: Eauldane Date: Mon, 15 Sep 2025 02:50:45 +0100 Subject: [PATCH] PGSQL Thread safety checks turned back on until we're confident; performance gain is negligible by having them off --- MareSynchronosServer/MareSynchronosAuthService/Startup.cs | 4 ++-- .../MareSynchronosServer/Services/SystemInfoService.cs | 2 +- MareSynchronosServer/MareSynchronosServer/Startup.cs | 4 ++-- MareSynchronosServer/MareSynchronosServices/Startup.cs | 2 +- .../MareSynchronosStaticFilesServer/Startup.cs | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/MareSynchronosServer/MareSynchronosAuthService/Startup.cs b/MareSynchronosServer/MareSynchronosAuthService/Startup.cs index df0bde1..99f3b35 100644 --- a/MareSynchronosServer/MareSynchronosAuthService/Startup.cs +++ b/MareSynchronosServer/MareSynchronosAuthService/Startup.cs @@ -214,7 +214,7 @@ public class Startup builder.MigrationsHistoryTable("_efmigrationshistory", "public"); builder.MigrationsAssembly("MareSynchronosShared"); }).UseSnakeCaseNamingConvention(); - options.EnableThreadSafetyChecks(false); + options.EnableThreadSafetyChecks(); }, mareConfig.GetValue(nameof(MareConfigurationBase.DbContextPoolSize), 1024)); services.AddDbContextFactory(options => { @@ -223,7 +223,7 @@ public class Startup builder.MigrationsHistoryTable("_efmigrationshistory", "public"); builder.MigrationsAssembly("MareSynchronosShared"); }).UseSnakeCaseNamingConvention(); - options.EnableThreadSafetyChecks(false); + options.EnableThreadSafetyChecks(); }); } } diff --git a/MareSynchronosServer/MareSynchronosServer/Services/SystemInfoService.cs b/MareSynchronosServer/MareSynchronosServer/Services/SystemInfoService.cs index 5ea53ac..1df7e6a 100644 --- a/MareSynchronosServer/MareSynchronosServer/Services/SystemInfoService.cs +++ b/MareSynchronosServer/MareSynchronosServer/Services/SystemInfoService.cs @@ -67,7 +67,7 @@ public class SystemInfoService : IHostedService, IDisposable { _logger.LogTrace("Sending System Info, Online Users: {onlineUsers}", onlineUsers); - _hubContext.Clients.All.Client_UpdateSystemInfo(SystemInfoDto); + _ = _hubContext.Clients.All.Client_UpdateSystemInfo(SystemInfoDto); using var scope = _services.CreateScope(); using var db = scope.ServiceProvider.GetService()!; diff --git a/MareSynchronosServer/MareSynchronosServer/Startup.cs b/MareSynchronosServer/MareSynchronosServer/Startup.cs index 3cc6807..e326288 100644 --- a/MareSynchronosServer/MareSynchronosServer/Startup.cs +++ b/MareSynchronosServer/MareSynchronosServer/Startup.cs @@ -245,7 +245,7 @@ public class Startup builder.MigrationsHistoryTable("_efmigrationshistory", "public"); builder.MigrationsAssembly("MareSynchronosShared"); }).UseSnakeCaseNamingConvention(); - options.EnableThreadSafetyChecks(false); + options.EnableThreadSafetyChecks(); }, mareConfig.GetValue(nameof(MareConfigurationBase.DbContextPoolSize), 1024)); services.AddDbContextFactory(options => { @@ -254,7 +254,7 @@ public class Startup builder.MigrationsHistoryTable("_efmigrationshistory", "public"); builder.MigrationsAssembly("MareSynchronosShared"); }).UseSnakeCaseNamingConvention(); - options.EnableThreadSafetyChecks(false); + options.EnableThreadSafetyChecks(); }); } diff --git a/MareSynchronosServer/MareSynchronosServices/Startup.cs b/MareSynchronosServer/MareSynchronosServices/Startup.cs index e8b7437..800e30a 100644 --- a/MareSynchronosServer/MareSynchronosServices/Startup.cs +++ b/MareSynchronosServer/MareSynchronosServices/Startup.cs @@ -45,7 +45,7 @@ public class Startup { builder.MigrationsHistoryTable("_efmigrationshistory", "public"); }).UseSnakeCaseNamingConvention(); - options.EnableThreadSafetyChecks(false); + options.EnableThreadSafetyChecks(); }, Configuration.GetValue(nameof(MareConfigurationBase.DbContextPoolSize), 1024)); services.AddSingleton(m => new MareMetrics(m.GetService>(), new List { }, diff --git a/MareSynchronosServer/MareSynchronosStaticFilesServer/Startup.cs b/MareSynchronosServer/MareSynchronosStaticFilesServer/Startup.cs index bb4cc89..3c86a44 100644 --- a/MareSynchronosServer/MareSynchronosStaticFilesServer/Startup.cs +++ b/MareSynchronosServer/MareSynchronosStaticFilesServer/Startup.cs @@ -108,7 +108,7 @@ public class Startup { builder.MigrationsHistoryTable("_efmigrationshistory", "public"); }).UseSnakeCaseNamingConvention(); - options.EnableThreadSafetyChecks(false); + options.EnableThreadSafetyChecks(); }, mareConfig.GetValue(nameof(MareConfigurationBase.DbContextPoolSize), 1024)); var signalRServiceBuilder = services.AddSignalR(hubOptions =>